Skip to content

Make the showAndLogExceptionWithTelemetry function work without the vscode module#2513

Merged
koesie10 merged 5 commits intomainfrom
koesie10/show-telemetry-without-vscode
Jun 16, 2023
Merged

Make the showAndLogExceptionWithTelemetry function work without the vscode module#2513
koesie10 merged 5 commits intomainfrom
koesie10/show-telemetry-without-vscode

Conversation

@koesie10
Copy link
Copy Markdown
Member

This makes the showAndLogExceptionWithTelemetry function callable without depending on the vscode module. This makes it easier to test and mock.

Please review this PR commit-by-commit.

Unfortunately, most of the call sites are still using telemetryListener as argument rather than app.telemetry. I'm hoping that this will be fixed in the future as we move more to using the App.

Checklist

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@koesie10 koesie10 force-pushed the koesie10/show-telemetry-without-vscode branch from 3fbb97d to c7dcc5e Compare June 14, 2023 09:35
@koesie10 koesie10 force-pushed the koesie10/show-telemetry-without-vscode branch from c7dcc5e to 7a76e20 Compare June 14, 2023 09:59
@koesie10 koesie10 marked this pull request as ready for review June 14, 2023 14:46
@koesie10 koesie10 requested review from a team as code owners June 14, 2023 14:46
Base automatically changed from koesie10/show-and-log-without-vscode to main June 15, 2023 07:29
Copy link
Copy Markdown
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@koesie10 koesie10 merged commit 0f9d127 into main Jun 16, 2023
@koesie10 koesie10 deleted the koesie10/show-telemetry-without-vscode branch June 16, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants